External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

security: Document @restore member of transaction list

Browse Source 
Both DAC and SELinux drivers support transactions. Each item on
the transaction list consists of various variables and @restore
is one of them. Document it so that as the list of variables grow
it's easier to spot which variable does what.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2019-02-15 11:23:29 +01:00
parent 5214b2f1a3
commit cc503c75c7
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/security/security_dac.c
View File

@ -79,7 +79,7 @@ struct _virSecurityDACChownItem {
const virStorageSource *src; const virStorageSource *src;
uid_t uid; uid_t uid;
gid_t gid; gid_t gid;
bool restore; bool restore; /* Whether current operation is 'set' or 'restore' */
}; };
typedef struct _virSecurityDACChownList virSecurityDACChownList; typedef struct _virSecurityDACChownList virSecurityDACChownList;
@ -155,8 +155,11 @@ virSecurityDACChownListFree(void *opaque)
* @src: disk source to chown * @src: disk source to chown
* @uid: user ID * @uid: user ID
* @gid: group ID * @gid: group ID
* @restore: if current operation is set or restore
* *
* Appends an entry onto transaction list. * Appends an entry onto transaction list.
* The @restore should be true if the operation is restoring
* seclabel and false otherwise.
* *
* Returns: 1 in case of successful append * Returns: 1 in case of successful append
* 0 if there is no transaction enabled * 0 if there is no transaction enabled

5
src/security/security_selinux.c
View File

@ -82,7 +82,7 @@ struct _virSecuritySELinuxContextItem {
char *path; char *path;
char *tcon; char *tcon;
bool optional; bool optional;
bool restore; bool restore; /* Whether current operation is 'set' or 'restore' */
}; };
typedef struct _virSecuritySELinuxContextList virSecuritySELinuxContextList; typedef struct _virSecuritySELinuxContextList virSecuritySELinuxContextList;
@ -168,8 +168,11 @@ virSecuritySELinuxContextListFree(void *opaque)
* @path: Path to chown * @path: Path to chown
* @tcon: target context * @tcon: target context
* @optional: true if setting @tcon is optional * @optional: true if setting @tcon is optional
* @restore: if current operation is set or restore
* *
* Appends an entry onto transaction list. * Appends an entry onto transaction list.
* The @restore should be true if the operation is restoring
* seclabel and false otherwise.
* *
* Returns: 1 in case of successful append * Returns: 1 in case of successful append
* 0 if there is no transaction enabled * 0 if there is no transaction enabled