External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

conf: virdomainobjlist: Introduce 'virDomainObjListCollectAll'

Browse Source 
Introduce a helper which will return a list of all domain objects inside
of the list without filtering and thus without the need to lock
individual members.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2022-07-13 15:18:56 +02:00
parent f52bc2d54a
commit cd3599c876
3 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/conf/virdomainobjlist.c
View File

@ -913,6 +913,24 @@ virDomainObjListCollectIterator(void *payload,
} }
void
virDomainObjListCollectAll(virDomainObjList *domlist,
virDomainObj ***vms,
size_t *nvms)
{
struct virDomainListData data = { NULL, 0 };
virObjectRWLockRead(domlist);
data.vms = g_new0(virDomainObj *, virHashSize(domlist->objs));
virHashForEach(domlist->objs, virDomainObjListCollectIterator, &data);
virObjectRWUnlock(domlist);
*nvms = data.nvms;
*vms = data.vms;
}
static void static void
virDomainObjListFilter(virDomainObj ***list, virDomainObjListFilter(virDomainObj ***list,
size_t *nvms, size_t *nvms,
@ -954,18 +972,8 @@ virDomainObjListCollect(virDomainObjList *domlist,
virDomainObjListACLFilter filter, virDomainObjListACLFilter filter,
unsigned int flags) unsigned int flags)
{ {
struct virDomainListData data = { NULL, 0 }; virDomainObjListCollectAll(domlist, vms, nvms);
virDomainObjListFilter(vms, nvms, conn, filter, flags);
virObjectRWLockRead(domlist);
data.vms = g_new0(virDomainObj *, virHashSize(domlist->objs));
virHashForEach(domlist->objs, virDomainObjListCollectIterator, &data);
virObjectRWUnlock(domlist);
virDomainObjListFilter(&data.vms, &data.nvms, conn, filter, flags);
*nvms = data.nvms;
*vms = data.vms;
return 0; return 0;
} }

4
src/conf/virdomainobjlist.h
View File

@ -145,6 +145,10 @@ virDomainObjListForEach(virDomainObjList *doms,
VIR_CONNECT_LIST_DOMAINS_FILTERS_SNAPSHOT | \ VIR_CONNECT_LIST_DOMAINS_FILTERS_SNAPSHOT | \
VIR_CONNECT_LIST_DOMAINS_FILTERS_CHECKPOINT) VIR_CONNECT_LIST_DOMAINS_FILTERS_CHECKPOINT)
void
virDomainObjListCollectAll(virDomainObjList *domlist,
virDomainObj ***vms,
size_t *nvms);
int int
virDomainObjListCollect(virDomainObjList *doms, virDomainObjListCollect(virDomainObjList *doms,
virConnectPtr conn, virConnectPtr conn,

1
src/libvirt_private.syms
View File

@ -1209,6 +1209,7 @@ virDomainMomentObjNew;
# conf/virdomainobjlist.h # conf/virdomainobjlist.h
virDomainObjListAdd; virDomainObjListAdd;
virDomainObjListCollect; virDomainObjListCollect;
virDomainObjListCollectAll;
virDomainObjListConvert; virDomainObjListConvert;
virDomainObjListExport; virDomainObjListExport;
virDomainObjListFindByID; virDomainObjListFindByID;