External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 15:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: Remove PATH_MAX sized stack allocation from iSCSI backend

Browse Source
This commit is contained in:
Matthias Bolte 2011-04-03 11:21:30 +02:00
parent 651a9529b2
commit cd708ef4ea
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/storage/storage_backend_iscsi.c
View File

@ -408,12 +408,15 @@ static int
virStorageBackendISCSIFindLUs(virStoragePoolObjPtr pool, virStorageBackendISCSIFindLUs(virStoragePoolObjPtr pool,
const char *session) const char *session)
{ {
char sysfs_path[PATH_MAX]; char *sysfs_path;
int retval = 0; int retval = 0;
uint32_t host; uint32_t host;
snprintf(sysfs_path, PATH_MAX, if (virAsprintf(&sysfs_path,
"/sys/class/iscsi_session/session%s/device", session); "/sys/class/iscsi_session/session%s/device", session) < 0) {
virReportOOMError();
return -1;
}
if (virStorageBackendSCSIGetHostNumber(sysfs_path, &host) < 0) { if (virStorageBackendSCSIGetHostNumber(sysfs_path, &host) < 0) {
virReportSystemError(errno, virReportSystemError(errno,
@ -429,6 +432,8 @@ virStorageBackendISCSIFindLUs(virStoragePoolObjPtr pool,
retval = -1; retval = -1;
} }
VIR_FREE(sysfs_path);
return retval; return retval;
} }