External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 19:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

uml: Resolve leak if need to requery in umlIdentifyOneChrPTY()

Browse Source 
Coverity noted that in the retry logic loop if res had been set, then
it could be leaked so add a VIR_FREE(res) prior to retry.
This commit is contained in:
John Ferlan 2013-01-30 09:54:41 -05:00
parent 40ef77cd86
commit ce6de782e9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/uml/uml_driver.c
View File

@ -1,7 +1,7 @@
/* /*
* uml_driver.c: core driver methods for managing UML guests * uml_driver.c: core driver methods for managing UML guests
* *
* Copyright (C) 2006-2012 Red Hat, Inc. * Copyright (C) 2006-2013 Red Hat, Inc.
* Copyright (C) 2006-2008 Daniel P. Berrange * Copyright (C) 2006-2008 Daniel P. Berrange
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
@ -261,6 +261,7 @@ requery:
/* XXX should do this in a better non-blocking /* XXX should do this in a better non-blocking
way somehow ...perhaps register a timer */ way somehow ...perhaps register a timer */
if (retries++ < 50) { if (retries++ < 50) {
VIR_FREE(res);
usleep(1000*10); usleep(1000*10);
goto requery; goto requery;
} }