External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools/virsh-pool: refactor smaller functions

Browse Source 
I think these functions look much more readable with just simple
if conditions.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Kristina Hanicova 2021-09-15 16:27:15 +02:00 committed by Michal Privoznik
parent 306a1ee685
commit ceb0d2b71a
1 changed files with 32 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
tools/virsh-pool.c
View File

@ -269,7 +269,6 @@ cmdPoolCreate(vshControl *ctl, const vshCmd *cmd)
{ {
virStoragePoolPtr pool; virStoragePoolPtr pool;
const char *from = NULL; const char *from = NULL;
bool ret = true;
g_autofree char *buffer = NULL; g_autofree char *buffer = NULL;
bool build; bool build;
bool overwrite; bool overwrite;
@ -297,17 +296,15 @@ cmdPoolCreate(vshControl *ctl, const vshCmd *cmd)
if (virFileReadAll(from, VSH_MAX_XML_FILE, &buffer) < 0) if (virFileReadAll(from, VSH_MAX_XML_FILE, &buffer) < 0)
return false; return false;
pool = virStoragePoolCreateXML(priv->conn, buffer, flags); if (!(pool = virStoragePoolCreateXML(priv->conn, buffer, flags))) {
if (pool != NULL) {
vshPrintExtra(ctl, _("Pool %s created from %s\n"),
virStoragePoolGetName(pool), from);
virStoragePoolFree(pool);
} else {
vshError(ctl, _("Failed to create pool from %s"), from); vshError(ctl, _("Failed to create pool from %s"), from);
ret = false; return false;
} }
return ret;
vshPrintExtra(ctl, _("Pool %s created from %s\n"),
virStoragePoolGetName(pool), from);
virStoragePoolFree(pool);
return true;
} }
static const vshCmdOptDef opts_pool_define_as[] = { static const vshCmdOptDef opts_pool_define_as[] = {
@ -490,17 +487,16 @@ cmdPoolCreateAs(vshControl *ctl, const vshCmd *cmd)
if (printXML) { if (printXML) {
vshPrint(ctl, "%s", xml); vshPrint(ctl, "%s", xml);
} else { return true;
pool = virStoragePoolCreateXML(priv->conn, xml, flags);
if (pool != NULL) {
vshPrintExtra(ctl, _("Pool %s created\n"), name);
virStoragePoolFree(pool);
} else {
vshError(ctl, _("Failed to create pool %s"), name);
return false;
}
} }
if (!(pool = virStoragePoolCreateXML(priv->conn, xml, flags))) {
vshError(ctl, _("Failed to create pool %s"), name);
return false;
}
vshPrintExtra(ctl, _("Pool %s created\n"), name);
virStoragePoolFree(pool);
return true; return true;
} }
@ -532,7 +528,6 @@ cmdPoolDefine(vshControl *ctl, const vshCmd *cmd)
{ {
virStoragePoolPtr pool; virStoragePoolPtr pool;
const char *from = NULL; const char *from = NULL;
bool ret = true;
g_autofree char *buffer = NULL; g_autofree char *buffer = NULL;
unsigned int flags = 0; unsigned int flags = 0;
virshControl *priv = ctl->privData; virshControl *priv = ctl->privData;
@ -546,17 +541,15 @@ cmdPoolDefine(vshControl *ctl, const vshCmd *cmd)
if (virFileReadAll(from, VSH_MAX_XML_FILE, &buffer) < 0) if (virFileReadAll(from, VSH_MAX_XML_FILE, &buffer) < 0)
return false; return false;
pool = virStoragePoolDefineXML(priv->conn, buffer, flags); if (!(pool = virStoragePoolDefineXML(priv->conn, buffer, flags))) {
if (pool != NULL) {
vshPrintExtra(ctl, _("Pool %s defined from %s\n"),
virStoragePoolGetName(pool), from);
virStoragePoolFree(pool);
} else {
vshError(ctl, _("Failed to define pool from %s"), from); vshError(ctl, _("Failed to define pool from %s"), from);
ret = false; return false;
} }
return ret;
vshPrintExtra(ctl, _("Pool %s defined from %s\n"),
virStoragePoolGetName(pool), from);
virStoragePoolFree(pool);
return true;
} }
/* /*
@ -586,17 +579,16 @@ cmdPoolDefineAs(vshControl *ctl, const vshCmd *cmd)
if (printXML) { if (printXML) {
vshPrint(ctl, "%s", xml); vshPrint(ctl, "%s", xml);
} else { return true;
pool = virStoragePoolDefineXML(priv->conn, xml, 0);
if (pool != NULL) {
vshPrintExtra(ctl, _("Pool %s defined\n"), name);
virStoragePoolFree(pool);
} else {
vshError(ctl, _("Failed to define pool %s"), name);
return false;
}
} }
if (!(pool = virStoragePoolDefineXML(priv->conn, xml, 0))) {
vshError(ctl, _("Failed to define pool %s"), name);
return false;
}
vshPrintExtra(ctl, _("Pool %s defined\n"), name);
virStoragePoolFree(pool);
return true; return true;
} }