From cefa185c1f75e5b3344823311a466b61ba74ff4f Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 17 Mar 2008 15:10:48 +0000 Subject: [PATCH] Fix creation of unmanaged pools --- ChangeLog | 6 ++++++ src/storage_driver.c | 8 ++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5b92497f47..10ccfe304e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Mon Mar 17 11:10:22 EDT 2008 Daniel P. Berrange + + * src/storage_driver.c: Don't crash if backend is missing the + startPool operation, and run refreshPool when creating an + unmanaged pool + Mon Mar 17 11:09:22 EDT 2008 Daniel P. Berrange * src/storage_backend.c: Cope with missing SELinux context diff --git a/src/storage_driver.c b/src/storage_driver.c index 2fa06af21c..fc3db4cd07 100644 --- a/src/storage_driver.c +++ b/src/storage_driver.c @@ -416,8 +416,12 @@ storagePoolCreate(virConnectPtr conn, return NULL; } - if (backend->startPool(conn, pool) < 0) { - virStoragePoolObjRemove(driver, pool); + if (backend->startPool && + backend->startPool(conn, pool) < 0) + return NULL; + if (backend->refreshPool(conn, pool) < 0) { + if (backend->stopPool) + backend->stopPool(conn, pool); return NULL; } pool->active = 1;