From cfbbeb36cf204fb2d87d45c5b8e9e676afefdfcd Mon Sep 17 00:00:00 2001
From: John Ferlan <jferlan@redhat.com>
Date: Wed, 27 Aug 2014 07:48:37 -0400
Subject: [PATCH] xen_xm: Resolve Coverity USE_AFTER_FREE

If virDomainDiskDefFree(disk) is called in 'skipdisk:', then it's possible
to either return to skipdisk without reallocating a new disk (via the if
condition just prior) or to end the loop having deleted the disk. Since
virDomainDiskDefFree() does not pass by reference, disk isn't changed in
this context, thus the possible issue.
---
 src/xenconfig/xen_xm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c
index fe46d91744..1e57e2488e 100644
--- a/src/xenconfig/xen_xm.c
+++ b/src/xenconfig/xen_xm.c
@@ -201,6 +201,7 @@ xenParseXMDisk(virConfPtr conf, virDomainDefPtr def, int xendConfigVersion)
             skipdisk:
             list = list->next;
             virDomainDiskDefFree(disk);
+            disk = NULL;
         }
     }