External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-27 05:42:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: don't alter state in $HOME

Browse Source 
Diego reported a bug where virsh tries to initialize a readline
history directory during 'make check' run as root, but fails
because /root was read-only.

It turns out that I could reproduce this as non-root, by using:

mv ~/.virsh{,.bak}
chmod a-w ~
make check -C tests TESTS=int-overflow
chmod u+w ~
mv ~/.virsh{.bak,}

* tests/int-overflow: Don't trigger interactive mode.
Reported by Diego Elio Pettenò.
This commit is contained in:
Eric Blake 2011-03-23 14:16:02 -06:00
parent ef701fd8cb
commit d0c7254bf1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/int-overflow
View File

@ -14,9 +14,9 @@ fi
. "$srcdir/test-lib.sh" . "$srcdir/test-lib.sh"
echo "error: failed to get domain '4294967298'" > exp || fail=1 echo "error: failed to get domain '4294967298'" > exp || fail=1
echo domname 4294967298 | $abs_top_builddir/tools/virsh --quiet \ $abs_top_builddir/tools/virsh --quiet \
--connect test://$abs_top_srcdir/examples/xml/test/testnode.xml \ --connect test://$abs_top_srcdir/examples/xml/test/testnode.xml \
> /dev/null 2> err || fail=1 'domname 4294967298; quit' > /dev/null 2> err || fail=1
diff -u err exp || fail=1 diff -u err exp || fail=1
exit $fail exit $fail