mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-03-07 17:28:15 +00:00
doc: fix typos in hacking.html.in; mark HACKING as read-only
* HACKING: Mark as read-only. Soon we'll generate it from... * docs/hacking.html.in: ... this file. More typo fixes.
This commit is contained in:
parent
06b835607f
commit
d1c754168a
3
HACKING
3
HACKING
@ -1,3 +1,6 @@
|
|||||||
|
-*- buffer-read-only: t -*- vi: set ro:
|
||||||
|
DO NOT EDIT THIS FILE! IT IS GENERATED AUTOMATICALLY!
|
||||||
|
|
||||||
Libvirt contributor guidelines
|
Libvirt contributor guidelines
|
||||||
==============================
|
==============================
|
||||||
|
|
||||||
|
@ -117,7 +117,7 @@
|
|||||||
</pre>
|
</pre>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
Note that sometimes you'll have to postprocess that output further, by
|
Note that sometimes you'll have to post-process that output further, by
|
||||||
piping it through "expand -i", since some leading TABs can get through.
|
piping it through "expand -i", since some leading TABs can get through.
|
||||||
Usually they're in macro definitions or strings, and should be converted
|
Usually they're in macro definitions or strings, and should be converted
|
||||||
anyhow.
|
anyhow.
|
||||||
@ -424,7 +424,7 @@
|
|||||||
#include <limits.h>
|
#include <limits.h>
|
||||||
|
|
||||||
#if HAVE_NUMACTL Some system includes aren't supported
|
#if HAVE_NUMACTL Some system includes aren't supported
|
||||||
# include <numa.h> everywhere so need these #if defences.
|
# include <numa.h> everywhere so need these #if guards.
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#include "internal.h" Include this first, after system includes.
|
#include "internal.h" Include this first, after system includes.
|
||||||
@ -533,7 +533,7 @@
|
|||||||
|
|
||||||
|
|
||||||
|
|
||||||
<h2><a name="committers">Libvirt committers guidelines</a></h2>
|
<h2><a name="committers">Libvirt committer guidelines</a></h2>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
The AUTHORS files indicates the list of people with commit access right
|
The AUTHORS files indicates the list of people with commit access right
|
||||||
@ -541,11 +541,12 @@
|
|||||||
</p>
|
</p>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
The general rule for committing patches is to make sure it has been reviewed
|
The general rule for committing a patch is to make sure
|
||||||
properly in the mailing-list first, usually if a couple of persons gave an
|
it has been reviewed
|
||||||
|
properly in the mailing-list first, usually if a couple of people gave an
|
||||||
ACK or +1 to a patch and nobody raised an objection on the list it should
|
ACK or +1 to a patch and nobody raised an objection on the list it should
|
||||||
be good to go. If the patch touches a part of the code where you're not the
|
be good to go. If the patch touches a part of the code where you're not
|
||||||
main maintainer, or where you donot have a very clear idea of
|
the main maintainer, or where you do not have a very clear idea of
|
||||||
how things work, it's better
|
how things work, it's better
|
||||||
to wait for a more authoritative feedback though. Before committing, please
|
to wait for a more authoritative feedback though. Before committing, please
|
||||||
also rebuild locally, run 'make check syntax-check', and make sure you
|
also rebuild locally, run 'make check syntax-check', and make sure you
|
||||||
|
Loading…
x
Reference in New Issue
Block a user