External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

commandhelper: Simplify envsort

Browse Source 
This saves two invocations of each `strndup` and `free`.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Tim Wiederhake 2021-02-01 12:27:47 +01:00 committed by Peter Krempa
parent 9f9b133e0c
commit d274092131
1 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tests/commandhelper.c
View File

@ -37,24 +37,19 @@ extern char **environ;
static int envsort(const void *a, const void *b) static int envsort(const void *a, const void *b)
{ {
const char *const*astrptr = a; const char *astr = *(const char**)a;
const char *const*bstrptr = b; const char *bstr = *(const char**)b;
const char *astr = *astrptr;
const char *bstr = *bstrptr;
char *aeq = strchr(astr, '=');
char *beq = strchr(bstr, '=');
char *akey;
char *bkey;
int ret;
if (!(akey = strndup(astr, aeq - astr))) while (true) {
abort(); char achar = (*astr == '=') ? '\0' : *astr;
if (!(bkey = strndup(bstr, beq - bstr))) char bchar = (*bstr == '=') ? '\0' : *bstr;
abort();
ret = strcmp(akey, bkey); if ((achar == '\0') || (achar != bchar))
free(akey); return achar - bchar;
free(bkey);
return ret; astr++;
bstr++;
}
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {