util: Fix naming in util/virnodesuspend

That file has only two exported files and each one of them has
different naming.  virNode is what all the other files use, so let's
use it.  It wasn't used before because the clash with public API
naming, so let's fix that by shortening the name (there is no other
private variant of it anyway).

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2017-03-07 10:44:06 +01:00
parent 26ae4e482a
commit d2d1dec1f5
7 changed files with 19 additions and 17 deletions

View File

@ -2174,7 +2174,7 @@ virNetlinkStartup;
# util/virnodesuspend.h # util/virnodesuspend.h
nodeSuspendForDuration; virNodeSuspend;
virNodeSuspendGetTargetMask; virNodeSuspendGetTargetMask;

View File

@ -5342,7 +5342,7 @@ lxcNodeSuspendForDuration(virConnectPtr conn,
if (virNodeSuspendForDurationEnsureACL(conn) < 0) if (virNodeSuspendForDurationEnsureACL(conn) < 0)
return -1; return -1;
return nodeSuspendForDuration(target, duration, flags); return virNodeSuspend(target, duration, flags);
} }

View File

@ -18400,7 +18400,7 @@ qemuNodeSuspendForDuration(virConnectPtr conn,
if (virNodeSuspendForDurationEnsureACL(conn) < 0) if (virNodeSuspendForDurationEnsureACL(conn) < 0)
return -1; return -1;
return nodeSuspendForDuration(target, duration, flags); return virNodeSuspend(target, duration, flags);
} }
static int static int

View File

@ -2877,7 +2877,7 @@ umlNodeSuspendForDuration(virConnectPtr conn,
if (virNodeSuspendForDurationEnsureACL(conn) < 0) if (virNodeSuspendForDurationEnsureACL(conn) < 0)
return -1; return -1;
return nodeSuspendForDuration(target, duration, flags); return virNodeSuspend(target, duration, flags);
} }

View File

@ -96,23 +96,23 @@ static int virNodeSuspendSetNodeWakeup(unsigned long long alarmTime)
} }
/** /**
* virNodeSuspend: * virNodeSuspendHelper:
* @cmdString: pointer to the command string this thread has to execute. * @cmdString: pointer to the command string this thread has to execute.
* *
* Actually perform the suspend operation by invoking the command. * Actually perform the suspend operation by invoking the command.
* Give a short delay before executing the command so as to give a chance * Give a short delay before executing the command so as to give a chance
* to virNodeSuspendForDuration() to return the status to the caller. * to virNodeSuspend() to return the status to the caller.
* If we don't give this delay, that function will not be able to return * If we don't give this delay, that function will not be able to return
* the status, since the suspend operation would have begun and hence no * the status, since the suspend operation would have begun and hence no
* data can be sent through the connection to the caller. However, with * data can be sent through the connection to the caller. However, with
* this delay added, the status return is best-effort only. * this delay added, the status return is best-effort only.
*/ */
static void virNodeSuspend(void *cmdString) static void virNodeSuspendHelper(void *cmdString)
{ {
virCommandPtr suspendCmd = virCommandNew((const char *)cmdString); virCommandPtr suspendCmd = virCommandNew((const char *)cmdString);
/* /*
* Delay for sometime so that the function nodeSuspendForDuration() * Delay for sometime so that the function virNodeSuspend()
* can return the status to the caller. * can return the status to the caller.
*/ */
sleep(SUSPEND_DELAY); sleep(SUSPEND_DELAY);
@ -131,7 +131,7 @@ static void virNodeSuspend(void *cmdString)
} }
/** /**
* nodeSuspendForDuration: * virNodeSuspend:
* @conn: pointer to the hypervisor connection * @conn: pointer to the hypervisor connection
* @target: the state to which the host must be suspended to - * @target: the state to which the host must be suspended to -
* VIR_NODE_SUSPEND_TARGET_MEM (Suspend-to-RAM), * VIR_NODE_SUSPEND_TARGET_MEM (Suspend-to-RAM),
@ -157,9 +157,9 @@ static void virNodeSuspend(void *cmdString)
* -1 if suspending the node is not supported, or if a previous suspend * -1 if suspending the node is not supported, or if a previous suspend
* operation is still in progress. * operation is still in progress.
*/ */
int nodeSuspendForDuration(unsigned int target, int virNodeSuspend(unsigned int target,
unsigned long long duration, unsigned long long duration,
unsigned int flags) unsigned int flags)
{ {
static virThread thread; static virThread thread;
const char *cmdString = NULL; const char *cmdString = NULL;
@ -219,7 +219,9 @@ int nodeSuspendForDuration(unsigned int target,
if (virNodeSuspendSetNodeWakeup(duration) < 0) if (virNodeSuspendSetNodeWakeup(duration) < 0)
goto cleanup; goto cleanup;
if (virThreadCreate(&thread, false, virNodeSuspend, (void *)cmdString) < 0) { if (virThreadCreate(&thread, false,
virNodeSuspendHelper,
(void *)cmdString) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Failed to create thread to suspend the host")); _("Failed to create thread to suspend the host"));
goto cleanup; goto cleanup;

View File

@ -25,9 +25,9 @@
# include "internal.h" # include "internal.h"
int nodeSuspendForDuration(unsigned int target, int virNodeSuspend(unsigned int target,
unsigned long long duration, unsigned long long duration,
unsigned int flags); unsigned int flags);
int virNodeSuspendGetTargetMask(unsigned int *bitmask); int virNodeSuspendGetTargetMask(unsigned int *bitmask);

View File

@ -2596,7 +2596,7 @@ xenUnifiedNodeSuspendForDuration(virConnectPtr conn,
if (virNodeSuspendForDurationEnsureACL(conn) < 0) if (virNodeSuspendForDurationEnsureACL(conn) < 0)
return -1; return -1;
return nodeSuspendForDuration(target, duration, flags); return virNodeSuspend(target, duration, flags);
} }