From d31219363039971de69d55ca92b90b5ea60e96a4 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Thu, 14 Jun 2012 11:20:17 -0600 Subject: [PATCH] Check for errors when parsing bridge interface XML The return status of virInterfaceDefParseBridge() was not being checked, potentially resulting in the creation of a broken interface. (cherry picked from commit cc004a664750e84a234d01ae4a5d774f7f980307) --- src/conf/interface_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 5601d3b87f..0aeb1e2d1a 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -769,7 +769,8 @@ virInterfaceDefParseXML(xmlXPathContextPtr ctxt, int parentIfType) { } def->data.bridge.delay = virXMLPropString(bridge, "delay"); ctxt->node = bridge; - virInterfaceDefParseBridge(def, ctxt); + if (virInterfaceDefParseBridge(def, ctxt) < 0) + goto error; break; } case VIR_INTERFACE_TYPE_BOND: {