External/libvirt
1
0
Fork 0
Code

security_dac: Fix TODO marks

Browse Source 
Correctly mark the places where we need to remember and recall
file ownership. We don't want to mislead any potential developer.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2015-10-07 11:16:08 +02:00
parent 499e302f96
commit d37d8f78c0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/security/security_dac.c
View File

@ -312,6 +312,7 @@ virSecurityDACSetOwnershipInternal(virSecurityDACDataPtr priv,
static int static int
virSecurityDACSetOwnership(const char *path, uid_t uid, gid_t gid) virSecurityDACSetOwnership(const char *path, uid_t uid, gid_t gid)
{ {
/* XXX record previous ownership */
return virSecurityDACSetOwnershipInternal(NULL, NULL, path, uid, gid); return virSecurityDACSetOwnershipInternal(NULL, NULL, path, uid, gid);
} }
@ -324,7 +325,7 @@ virSecurityDACRestoreSecurityFileLabelInternal(virSecurityDACDataPtr priv,
VIR_INFO("Restoring DAC user and group on '%s'", VIR_INFO("Restoring DAC user and group on '%s'",
NULLSTR(src ? src->path : path)); NULLSTR(src ? src->path : path));
/* XXX record previous ownership */ /* XXX recall previous ownership */
return virSecurityDACSetOwnershipInternal(priv, src, path, 0, 0); return virSecurityDACSetOwnershipInternal(priv, src, path, 0, 0);
} }