From d3f0708e84fc5cd422d13cf565d8150212fd727f Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Thu, 4 Sep 2014 16:27:58 -0400 Subject: [PATCH] network: Resolve Coverity FORWARD_NULL If the VIR_STRDUP(exptime,...) fails, then we will jump to cleanup, no need to check if exptime is set which causes Coverity to issue a complaint in the virStrToLong_ll call because there wasn't a check for a NULL value while there was one for the reference right after the VIR_STRDUP(). Signed-off-by: John Ferlan --- src/network/leaseshelper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index c8543a2dee..5b3c9c3bc7 100644 --- a/src/network/leaseshelper.c +++ b/src/network/leaseshelper.c @@ -180,8 +180,7 @@ main(int argc, char **argv) goto cleanup; /* Removed extraneous trailing space in DNSMASQ_LEASE_EXPIRES (dnsmasq < 2.52) */ - if (exptime && - exptime[strlen(exptime) - 1] == ' ') + if (exptime[strlen(exptime) - 1] == ' ') exptime[strlen(exptime) - 1] = '\0'; /* Check if it is an IPv6 lease */