External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-03 04:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

api: Allow keeping completed domain job stats when reading them

Browse Source 
virDomainGetJobStats destroys the completed statistics on the first
read. Give the user possibility to keep them around if they wish so.

Add a flag VIR_DOMAIN_JOB_STATS_KEEP_COMPLETED which will read the stats
without destroying them.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Peter Krempa 2019-11-22 13:23:31 +01:00
parent 54a9d6e51e
commit d4a4933a0d
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/libvirt/libvirt-domain.h
View File

@ -3246,6 +3246,8 @@ struct _virDomainJobInfo {
typedef enum {
VIR_DOMAIN_JOB_STATS_COMPLETED = 1 << 0, /* return stats of a recently
* completed job */
VIR_DOMAIN_JOB_STATS_KEEP_COMPLETED = 1 << 1, /* don't remove completed
stats when reading them */
} virDomainGetJobStatsFlags;
int virDomainGetJobInfo(virDomainPtr dom,

6
src/libvirt-domain.c
View File

@ -8796,7 +8796,8 @@ virDomainGetJobInfo(virDomainPtr domain, virDomainJobInfoPtr info)
* flag may be used to query statistics of a completed incoming pre-copy
* migration (statistics for post-copy migration are only available on the
* source host). Statistics of a completed job are automatically destroyed
* once read or when libvirtd is restarted. Note that time information
* once read (unless the VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP is used as well)
* or when libvirtd is restarted. Note that time information
* returned for completed migrations may be completely irrelevant unless both
* source and destination hosts have synchronized time (i.e., NTP daemon is
* running on both of them). The statistics of a completed job can also be
@ -8823,6 +8824,9 @@ virDomainGetJobStats(virDomainPtr domain,
virCheckNonNullArgGoto(type, error);
virCheckNonNullArgGoto(params, error);
virCheckNonNullArgGoto(nparams, error);
VIR_REQUIRE_FLAG_GOTO(VIR_DOMAIN_JOB_STATS_KEEP_COMPLETED,
VIR_DOMAIN_JOB_STATS_COMPLETED,
error);
conn = domain->conn;