External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 14:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

virMACMapHashDumper: Refactor array addition

Browse Source 
Use automatic memory freeing and don't check return value of
virJSONValueNewString as it can't fail.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-12 11:34:22 +01:00
parent 83a50fe2a5
commit d4e369a4c3
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/util/virmacmap.c
View File

@ -214,13 +214,11 @@ virMACMapHashDumper(void *payload,
GSList *next; GSList *next;
for (next = macs; next; next = next->next) { for (next = macs; next; next = next->next) {
virJSONValuePtr m = virJSONValueNewString((const char *) next->data); g_autoptr(virJSONValue) m = virJSONValueNewString((const char *) next->data);
if (!m || if (virJSONValueArrayAppend(arr, m) < 0)
virJSONValueArrayAppend(arr, m) < 0) {
virJSONValueFree(m);
return -1; return -1;
} m = NULL;
} }
if (virJSONValueObjectAppendString(obj, "domain", name) < 0 || if (virJSONValueObjectAppendString(obj, "domain", name) < 0 ||