From d56ddd0d19e34a8c0a7293473d8d4906e2590cd1 Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Wed, 19 Apr 2023 14:19:16 +0200 Subject: [PATCH] qemu: Check all watchdogs for iTCO duplicates The loop initially skipped the first one because it was mainly checking the incompatible actions, but was then modified to also check the duplicity of iTCO watchdogs. While at it change the type of the iteration variable to the usual size_t. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2187133 Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- src/qemu/qemu_validate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 6ebd2ba010..a03f7056b1 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1111,9 +1111,9 @@ static int qemuValidateDomainDefWatchdogs(const virDomainDef *def) { bool found_itco = false; - ssize_t i = 0; + size_t i = 0; - for (i = 1; i < def->nwatchdogs; i++) { + for (i = 0; i < def->nwatchdogs; i++) { /* We could theoretically support different watchdogs having dump and * pause, but let's be honest, we support multiple watchdogs only * because we need to be able to add a second, implicit one, not because