External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

openvzParseBarrierLimit: Rework string handling

Browse Source 
Use g_strsplit instead of virStringSplitCount and automatically free the
temporary string list.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-04-01 15:34:52 +02:00
parent 94e601f5e8
commit d5c9d168c4
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/openvz/openvz_conf.c
View File

@ -123,26 +123,21 @@ openvzParseBarrierLimit(const char* value,
unsigned long long *barrier,
unsigned long long *limit)
{
char **tmp = NULL;
size_t ntmp = 0;
int ret = -1;
g_auto(GStrv) tmp = NULL;
if (!(tmp = virStringSplitCount(value, ":", 0, &ntmp)))
goto error;
if (!(tmp = g_strsplit(value, ":", 0)))
return -1;
if (ntmp != 2)
goto error;
if (g_strv_length(tmp) != 2)
return -1;
if (barrier && virStrToLong_ull(tmp[0], NULL, 10, barrier) < 0)
goto error;
return -1;
if (limit && virStrToLong_ull(tmp[1], NULL, 10, limit) < 0)
goto error;
return -1;
ret = 0;
error:
virStringListFreeCount(tmp, ntmp);
return ret;
return 0;
}