External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-21 19:02:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use 'virBitmapNewCopy' instead of 'virBitmapCopy'

Browse Source 
There are only 3 places using the function. Two can use virBitmapNewCopy
directly. In case of the qemu capabilities code we need to free the old
bitmap first.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2020-10-02 10:26:34 +02:00
parent faa88866f5
commit d8a354954a
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/capabilities.c
View File

@ -1589,8 +1589,7 @@ virCapabilitiesHostNUMAInitFake(virCapsHostNUMAPtr caps)
cpus[cid].die_id = 0;
cpus[cid].socket_id = s;
cpus[cid].core_id = c;
cpus[cid].siblings = virBitmapNew(ncpus);
virBitmapCopy(cpus[cid].siblings, siblings);
cpus[cid].siblings = virBitmapNewCopy(siblings);
cid++;
}

3
src/qemu/qemu_capabilities.c
View File

@ -1932,7 +1932,8 @@ virQEMUCapsPtr virQEMUCapsNewCopy(virQEMUCapsPtr qemuCaps)
ret->ctime = qemuCaps->ctime;
virBitmapCopy(ret->flags, qemuCaps->flags);
virBitmapFree(ret->flags);
ret->flags = virBitmapNewCopy(qemuCaps->flags);
ret->version = qemuCaps->version;
ret->kvmVersion = qemuCaps->kvmVersion;

4
src/util/virresctrl.c
View File

@ -1158,9 +1158,9 @@ virResctrlAllocUpdateMask(virResctrlAllocPtr alloc,
return -1;
if (!a_type->masks[cache])
a_type->masks[cache] = virBitmapNew(virBitmapSize(mask));
a_type->masks[cache] = virBitmapNewCopy(mask);
return virBitmapCopy(a_type->masks[cache], mask);
return 0;
}