mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-22 12:35:17 +00:00
Fix virConnectOpen.*() name requirements
virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG used NULLSTR() for the output) and by default, if name == NULL, the default connection uri is used. This was not indicated in the documentation and wasn't checked for in other API's VIR_DEBUG outputs.
This commit is contained in:
parent
6af9c564c0
commit
d8ed386c07
@ -1334,7 +1334,7 @@ failed:
|
||||
|
||||
/**
|
||||
* virConnectOpen:
|
||||
* @name: URI of the hypervisor
|
||||
* @name: (optional) URI of the hypervisor
|
||||
*
|
||||
* This function should be called first to get a connection to the
|
||||
* Hypervisor and xen store
|
||||
@ -1362,7 +1362,7 @@ virConnectOpen(const char *name)
|
||||
if (virInitialize() < 0)
|
||||
goto error;
|
||||
|
||||
VIR_DEBUG("name=%s", name);
|
||||
VIR_DEBUG("name=%s", NULLSTR(name));
|
||||
virResetLastError();
|
||||
ret = do_open(name, NULL, 0);
|
||||
if (!ret)
|
||||
@ -1376,7 +1376,7 @@ error:
|
||||
|
||||
/**
|
||||
* virConnectOpenReadOnly:
|
||||
* @name: URI of the hypervisor
|
||||
* @name: (optional) URI of the hypervisor
|
||||
*
|
||||
* This function should be called first to get a restricted connection to the
|
||||
* library functionalities. The set of APIs usable are then restricted
|
||||
@ -1397,7 +1397,7 @@ virConnectOpenReadOnly(const char *name)
|
||||
if (virInitialize() < 0)
|
||||
goto error;
|
||||
|
||||
VIR_DEBUG("name=%s", name);
|
||||
VIR_DEBUG("name=%s", NULLSTR(name));
|
||||
virResetLastError();
|
||||
ret = do_open(name, NULL, VIR_CONNECT_RO);
|
||||
if (!ret)
|
||||
@ -1411,7 +1411,7 @@ error:
|
||||
|
||||
/**
|
||||
* virConnectOpenAuth:
|
||||
* @name: URI of the hypervisor
|
||||
* @name: (optional) URI of the hypervisor
|
||||
* @auth: Authenticate callback parameters
|
||||
* @flags: bitwise-OR of virConnectFlags
|
||||
*
|
||||
|
Loading…
x
Reference in New Issue
Block a user