External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virXMLPropULongLong: Always initialize @result

Browse Source 
Compilers aren't able to see whether @result is set or not and thus
don't warn of a potential use of uninitialized value. Always set @result
to prevent uninitialized use.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-05-06 14:00:16 +02:00
parent 0420c325ce
commit d919d9bbcd
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/virxml.c
View File

@ -762,6 +762,7 @@ virXMLPropUInt(xmlNodePtr node,
* @result: The returned value
*
* Convenience function to return value of an unsigned long long attribute.
* @result is initialized to 0 on error or if the element is not found.
*
* Returns 1 in case of success in which case @result is set,
* or 0 if the attribute is not present,
@ -778,6 +779,8 @@ virXMLPropULongLong(xmlNodePtr node,
int ret;
unsigned long long val;
*result = 0;
if (!(tmp = virXMLPropString(node, name))) {
if (!(flags & VIR_XML_PROP_REQUIRED))
return 0;