External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 21:47:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

nodedev: Use access instead of stat

Browse Source 
The use of 'stat' in nodeDeviceVportCreateDelete is only to check
if the file exists or not, it's a bit overkill, and safe to replace
with the wrapper of access(2) (virFileExists).
This commit is contained in:
Osier Yang 2013-01-08 01:05:30 +08:00
parent 244ce462e2
commit d91f7dec46
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node_device/node_device_driver.c
View File

@ -28,7 +28,6 @@
#include <errno.h>
#include <fcntl.h>
#include <time.h>
#include <sys/stat.h>
#include "virerror.h"
#include "datatypes.h"
@ -422,7 +421,6 @@ nodeDeviceVportCreateDelete(const int parent_host,
int retval = 0;
char *operation_path = NULL, *vport_name = NULL;
const char *operation_file = NULL;
struct stat st;
switch (operation) {
case VPORT_CREATE:
@ -450,7 +448,7 @@ nodeDeviceVportCreateDelete(const int parent_host,
goto cleanup;
}
if (stat(operation_path, &st) != 0) {
if (!virFileExists(operation_path)) {
VIR_FREE(operation_path);
if (virAsprintf(&operation_path,
"%shost%d%s",
@ -462,7 +460,7 @@ nodeDeviceVportCreateDelete(const int parent_host,
goto cleanup;
}
if (stat(operation_path, &st) != 0) {
if (!virFileExists(operation_path)) {
VIR_ERROR(_("No vport operation path found for host%d"),
parent_host);
retval = -1;