External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Substract isolcpus from all online affinity

Browse Source 
When starting a domain and there's no vCPU/emulator pinning set,
we query the list of all online physical CPUs and set affinity of
the child process (which eventually becomes QEMU) to that list.
We can't assume libvirtd itself had affinity to all online CPUs
and since affinity of the child process is inherited, we should
fix it afterwards. But that's not necessarily correct. Users
might isolate some physical CPUs and we should avoid touching
them unless explicitly told so (i.e. vCPU/emulator pinning told
us so).

Therefore, when attempting to set affinity to all online CPUs
subtract the isolated ones.

Before this commit:

  root@localhost:~# cat /sys/devices/system/cpu/isolated
  19,21,23
  root@virtlab414:~# taskset -cp $(pgrep qemu)
  pid 14835's current affinity list: 0-23

After:

  root@virtlab414:~# taskset -cp $(pgrep qemu)
  pid 17153's current affinity list: 0-18,20,22

Resolves: https://issues.redhat.com/browse/RHEL-33082
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Michal Privoznik 2024-04-22 11:55:46 +02:00
parent 3c948ef699
commit da95bcb6b2
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/qemu/qemu_process.c
View File

@ -2334,6 +2334,8 @@ qemuProcessDetectIOThreadPIDs(virDomainObj *vm,
static int static int
qemuProcessGetAllCpuAffinity(virBitmap **cpumapRet) qemuProcessGetAllCpuAffinity(virBitmap **cpumapRet)
{ {
g_autoptr(virBitmap) isolCpus = NULL;
*cpumapRet = NULL; *cpumapRet = NULL;
if (!virHostCPUHasBitmap()) if (!virHostCPUHasBitmap())
@ -2342,6 +2344,13 @@ qemuProcessGetAllCpuAffinity(virBitmap **cpumapRet)
if (!(*cpumapRet = virHostCPUGetOnlineBitmap())) if (!(*cpumapRet = virHostCPUGetOnlineBitmap()))
return -1; return -1;
if (virHostCPUGetIsolated(&isolCpus) < 0)
return -1;
if (isolCpus) {
virBitmapSubtract(*cpumapRet, isolCpus);
}
return 0; return 0;
} }