From dc3f02561713eebc58d2ee138308683f9d3248e9 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 4 Nov 2021 14:12:05 +0100 Subject: [PATCH] qemuBuildConsoleCommandLine: Remove identical code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unify the cases for SCLP/SCLPLM/VIRTIO consoles as the code is identical. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_command.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 5c2b8d65fd..fb4535e889 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9513,35 +9513,7 @@ qemuBuildConsoleCommandLine(virCommand *cmd, switch (console->targetType) { case VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SCLP: - if (!(devstr = qemuBuildChrChardevStr(cmd, - cfg, - console->source, - console->info.alias, - qemuCaps))) - return -1; - virCommandAddArg(cmd, "-chardev"); - virCommandAddArg(cmd, devstr); - VIR_FREE(devstr); - - if (qemuBuildChrDeviceCommandLine(cmd, def, console, qemuCaps) < 0) - return -1; - break; - case VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SCLPLM: - if (!(devstr = qemuBuildChrChardevStr(cmd, - cfg, - console->source, - console->info.alias, - qemuCaps))) - return -1; - virCommandAddArg(cmd, "-chardev"); - virCommandAddArg(cmd, devstr); - VIR_FREE(devstr); - - if (qemuBuildChrDeviceCommandLine(cmd, def, console, qemuCaps) < 0) - return -1; - break; - case VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO: if (!(devstr = qemuBuildChrChardevStr(cmd, cfg,