External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix actual vs. expected in virtTestCompareFiles

Browse Source 
Commit ca329299 added a utility function virtTestCompareFiles() to
eliminate repetitive code in several test programs. It unfortunately
calls virtTestDifference() with the arguments in the wrong order -
strcontent is the "actual" output gathered by the test rig, while
filecontent is the "expected", and virtTestDifference() wants expected
(filecontent) followed by actual (strcontent), but
virtTestCompareFiles() does the opposite, which can make the output a
bit confusing when there is a failure.
This commit is contained in:
Laine Stump 2015-04-27 13:43:06 -04:00
parent d8082d2d44
commit dcbedfa672
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/testutils.c
View File

@ -1,7 +1,7 @@
/*
* testutils.c: basic test utils
*
* Copyright (C) 2005-2014 Red Hat, Inc.
* Copyright (C) 2005-2015 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@ -641,7 +641,7 @@ virtTestCompareToFile(const char *strcontent,
goto failure;
goto out;
}
virtTestDifference(stderr, strcontent, filecontent);
virtTestDifference(stderr, filecontent, strcontent);
goto failure;
}