External/libvirt
1
0
Fork 0
Code

qemuDomainPinIOThread: Copy the cpu bitmap instead of re-parsing it

Browse Source 
The bitmap recorded in the live/persistent definition was re-parsed two
more times. We can copy it which is cheaper and less verbose.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2022-01-18 10:06:38 +01:00
parent a23ce0b956
commit dcfa6c650d
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/qemu/qemu_driver.c
View File

@ -5011,7 +5011,6 @@ qemuDomainPinIOThread(virDomainPtr dom,
if (def) {
virDomainIOThreadIDDef *iothrid;
virBitmap *cpumask;
if (!(iothrid = virDomainIOThreadIDFind(def, iothread_id))) {
virReportError(VIR_ERR_INVALID_ARG,
@ -5019,11 +5018,8 @@ qemuDomainPinIOThread(virDomainPtr dom,
goto endjob;
}
if (!(cpumask = virBitmapNewData(cpumap, maplen)))
goto endjob;
virBitmapFree(iothrid->cpumask);
iothrid->cpumask = cpumask;
iothrid->cpumask = virBitmapNewCopy(pcpumap);
iothrid->autofill = false;
/* Configure the corresponding cpuset cgroup before set affinity. */
@ -5060,7 +5056,6 @@ qemuDomainPinIOThread(virDomainPtr dom,
if (persistentDef) {
virDomainIOThreadIDDef *iothrid;
virBitmap *cpumask;
if (!(iothrid = virDomainIOThreadIDFind(persistentDef, iothread_id))) {
virReportError(VIR_ERR_INVALID_ARG,
@ -5068,11 +5063,8 @@ qemuDomainPinIOThread(virDomainPtr dom,
goto endjob;
}
if (!(cpumask = virBitmapNewData(cpumap, maplen)))
goto endjob;
virBitmapFree(iothrid->cpumask);
iothrid->cpumask = cpumask;
iothrid->cpumask = virBitmapNewCopy(pcpumap);
iothrid->autofill = false;
ret = virDomainDefSave(persistentDef, driver->xmlopt, cfg->configDir);