mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-12 15:52:55 +00:00
conf: log error on attempts to modify ACPI index of active device
The ACPI index of a device in a running guest can't be modified, and libvirt doesn't actually attempt to modify it, but it was possible for a user to request such a modification, and libvirt wouldn't complain, thus misleading the user into thinking that it had actually been changed. Resolves: https://bugzilla.redhat.com/1998920 Signed-off-by: Laine Stump <laine@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
cf916af4a1
commit
ddba9f1dc9
@ -28485,6 +28485,12 @@ virDomainDefCompatibleDevice(virDomainDef *def,
|
||||
_("changing device alias is not allowed"));
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (data.newInfo->acpiIndex != data.oldInfo->acpiIndex) {
|
||||
virReportError(VIR_ERR_OPERATION_DENIED, "%s",
|
||||
_("changing device 'acpi index' is not allowed"));
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
||||
if (!virDomainDefHasUSB(def) &&
|
||||
|
Loading…
x
Reference in New Issue
Block a user