External/libvirt
1
0
Fork 0
Code

qemuBuildNumaArgStr: Discard def->cpu check

Browse Source 
In the function at one place we check if def->cpu is NULL prior
to accessing def->cpu->ncells. Then, later in the code,
def->cpu->ncells is accessed directly, without the check. This
makes coverity unhappy, because the first check makes it think
def->cpu can be NULL. However, the function is not called if
def->cpu is NULL. Therefore, remove the first check and hopefully
make coverity cheer again.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2014-09-23 13:08:39 +02:00
parent f8857c8f88
commit de31dcc89a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_command.c
View File

@ -6594,7 +6594,7 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
continue; continue;
} }
if (def->cpu && def->cpu->ncells) { if (def->cpu->ncells) {
/* Fortunately, we allow only guest NUMA nodes to be continuous /* Fortunately, we allow only guest NUMA nodes to be continuous
* starting from zero. */ * starting from zero. */
pos = def->cpu->ncells - 1; pos = def->cpu->ncells - 1;