From e02b5722ed9d88b2e993eba829fc2bcc6c720aab Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Thu, 10 Aug 2017 09:14:36 +0200 Subject: [PATCH] virhostdevtest: Don't leak @mgr->activeSCSIHostdevs So the hostdev manager has some lists to keep track which devices are active (=assigned to a domain) or inactive. The manager and its lists are allocated in myInit and freed in myCleanup but one of them (activeSCSIHostdevs) was missing. Also, the order in which the cleanup was done doesn't make it easy to spot it, therefore reoder it. Signed-off-by: Michal Privoznik --- tests/virhostdevtest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 655991c3c8..0ad58ddf3d 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -73,8 +73,9 @@ myCleanup(void) virFileDeleteTree(mgr->stateDir); virObjectUnref(mgr->activePCIHostdevs); - virObjectUnref(mgr->inactivePCIHostdevs); virObjectUnref(mgr->activeUSBHostdevs); + virObjectUnref(mgr->inactivePCIHostdevs); + virObjectUnref(mgr->activeSCSIHostdevs); VIR_FREE(mgr->stateDir); VIR_FREE(mgr); }