conf: Introduce per-domain condition variable

Complex jobs, such as migration, need to monitor several events at once,
which is impossible when each of the event uses its own condition
variable. This patch adds a single condition variable to each domain
object. This variable can be used instead of the other event specific
conditions.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2015-05-26 16:43:58 +02:00
parent 355d8f470f
commit e0713c4bed
3 changed files with 57 additions and 0 deletions

View File

@ -2509,6 +2509,7 @@ static void virDomainObjDispose(void *obj)
virDomainObjPtr dom = obj; virDomainObjPtr dom = obj;
VIR_DEBUG("obj=%p", dom); VIR_DEBUG("obj=%p", dom);
virCondDestroy(&dom->cond);
virDomainDefFree(dom->def); virDomainDefFree(dom->def);
virDomainDefFree(dom->newDef); virDomainDefFree(dom->newDef);
@ -2529,6 +2530,12 @@ virDomainObjNew(virDomainXMLOptionPtr xmlopt)
if (!(domain = virObjectLockableNew(virDomainObjClass))) if (!(domain = virObjectLockableNew(virDomainObjClass)))
return NULL; return NULL;
if (virCondInit(&domain->cond) < 0) {
virReportSystemError(errno, "%s",
_("failed to initialize domain condition"));
goto error;
}
if (xmlopt->privateData.alloc) { if (xmlopt->privateData.alloc) {
if (!(domain->privateData = (xmlopt->privateData.alloc)())) if (!(domain->privateData = (xmlopt->privateData.alloc)()))
goto error; goto error;
@ -2651,6 +2658,46 @@ virDomainObjEndAPI(virDomainObjPtr *vm)
} }
void
virDomainObjSignal(virDomainObjPtr vm)
{
virCondSignal(&vm->cond);
}
void
virDomainObjBroadcast(virDomainObjPtr vm)
{
virCondBroadcast(&vm->cond);
}
int
virDomainObjWait(virDomainObjPtr vm)
{
if (virCondWait(&vm->cond, &vm->parent.lock) < 0) {
virReportSystemError(errno, "%s",
_("failed to wait for domain condition"));
return -1;
}
return 0;
}
int
virDomainObjWaitUntil(virDomainObjPtr vm,
unsigned long long whenms)
{
if (virCondWaitUntil(&vm->cond, &vm->parent.lock, whenms) < 0 &&
errno != ETIMEDOUT) {
virReportSystemError(errno, "%s",
_("failed to wait for domain condition"));
return -1;
}
return 0;
}
/* /*
* *
* If flags & VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE then * If flags & VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE then

View File

@ -2318,6 +2318,7 @@ typedef struct _virDomainObj virDomainObj;
typedef virDomainObj *virDomainObjPtr; typedef virDomainObj *virDomainObjPtr;
struct _virDomainObj { struct _virDomainObj {
virObjectLockable parent; virObjectLockable parent;
virCond cond;
pid_t pid; pid_t pid;
virDomainStateReason state; virDomainStateReason state;
@ -2437,6 +2438,11 @@ void virDomainObjEndAPI(virDomainObjPtr *vm);
bool virDomainObjTaint(virDomainObjPtr obj, bool virDomainObjTaint(virDomainObjPtr obj,
virDomainTaintFlags taint); virDomainTaintFlags taint);
void virDomainObjSignal(virDomainObjPtr vm);
void virDomainObjBroadcast(virDomainObjPtr vm);
int virDomainObjWait(virDomainObjPtr vm);
int virDomainObjWaitUntil(virDomainObjPtr vm,
unsigned long long whenms);
int virDomainDefCheckUnsupportedMemoryHotplug(virDomainDefPtr def); int virDomainDefCheckUnsupportedMemoryHotplug(virDomainDefPtr def);
int virDomainDeviceDefCheckUnsupportedMemoryDevice(virDomainDeviceDefPtr dev); int virDomainDeviceDefCheckUnsupportedMemoryDevice(virDomainDeviceDefPtr dev);

View File

@ -380,6 +380,7 @@ virDomainNetTypeToString;
virDomainNostateReasonTypeFromString; virDomainNostateReasonTypeFromString;
virDomainNostateReasonTypeToString; virDomainNostateReasonTypeToString;
virDomainObjAssignDef; virDomainObjAssignDef;
virDomainObjBroadcast;
virDomainObjCopyPersistentDef; virDomainObjCopyPersistentDef;
virDomainObjEndAPI; virDomainObjEndAPI;
virDomainObjFormat; virDomainObjFormat;
@ -409,8 +410,11 @@ virDomainObjParseNode;
virDomainObjSetDefTransient; virDomainObjSetDefTransient;
virDomainObjSetMetadata; virDomainObjSetMetadata;
virDomainObjSetState; virDomainObjSetState;
virDomainObjSignal;
virDomainObjTaint; virDomainObjTaint;
virDomainObjUpdateModificationImpact; virDomainObjUpdateModificationImpact;
virDomainObjWait;
virDomainObjWaitUntil;
virDomainOSTypeFromString; virDomainOSTypeFromString;
virDomainOSTypeToString; virDomainOSTypeToString;
virDomainParseMemory; virDomainParseMemory;