External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-08 22:15:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: Use g_autofree in virLogSetDefaultOutputToFile()

Browse Source 
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Fabiano Fidêncio 2019-12-19 10:11:49 +01:00
parent aa88882c41
commit e09f723bf1
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/virlog.c
View File

@ -173,8 +173,7 @@ virLogSetDefaultOutputToJournald(void)
static int
virLogSetDefaultOutputToFile(const char *binary, bool privileged)
{
int ret = -1;
char *logdir = NULL;
g_autofree char *logdir = NULL;
mode_t old_umask;
if (privileged) {
@ -182,12 +181,12 @@ virLogSetDefaultOutputToFile(const char *binary, bool privileged)
virLogDefaultPriority, LOCALSTATEDIR, binary);
} else {
if (!(logdir = virGetUserCacheDirectory()))
goto cleanup;
return -1;
old_umask = umask(077);
if (virFileMakePath(logdir) < 0) {
umask(old_umask);
goto cleanup;
return -1;
}
umask(old_umask);
@ -195,10 +194,7 @@ virLogSetDefaultOutputToFile(const char *binary, bool privileged)
virLogDefaultPriority, logdir, binary);
}
ret = 0;
cleanup:
VIR_FREE(logdir);
return ret;
return 0;
}