External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-17 07:07:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage/util: replace unnecessary while loop by if

Browse Source 
These while loops exit directly due to break after entering.
Use if instead of these while loops.

Signed-off-by: Jiang Jiacheng <jiangjiacheng@huawei.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Jiang Jiacheng 2023-01-05 19:51:08 +08:00 committed by Michal Privoznik
parent 022dcf076b
commit e128d337c9
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/storage_util.c
View File

@ -3784,12 +3784,10 @@ getNewStyleBlockDevice(const char *lun_path,
if (virDirOpen(&block_dir, block_path) < 0)
return -1;
while ((direrr = virDirRead(block_dir, &block_dirent, block_path)) > 0) {
if ((direrr = virDirRead(block_dir, &block_dirent, block_path)) > 0) {
*block_device = g_strdup(block_dirent->d_name);
VIR_DEBUG("Block device is '%s'", *block_device);
break;
}
if (direrr < 0)

6
src/util/virutil.c
View File

@ -1432,15 +1432,11 @@ virHostHasIOMMU(void)
{
g_autoptr(DIR) iommuDir = NULL;
struct dirent *iommuGroup = NULL;
int direrr;
if (virDirOpenQuiet(&iommuDir, "/sys/kernel/iommu_groups/") < 0)
return false;
while ((direrr = virDirRead(iommuDir, &iommuGroup, NULL)) > 0)
break;
if (direrr < 0 || !iommuGroup)
if (virDirRead(iommuDir, &iommuGroup, NULL) < 0 || !iommuGroup)
return false;
return true;