From e1424a97a9a1cbfd7b44529d36770971d14f7ba6 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Wed, 26 Aug 2009 15:38:32 +0100 Subject: [PATCH] Fix memory leak of monitor character device * src/qemu_driver.c: Free the vm->monitor_chr field at VM shutdown. Unlink the UNIX domain socket at VM shutdown to avoid littering FS with old sockets --- src/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index d424ce7bb0..2a8e6d1613 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2285,6 +2285,13 @@ static void qemudShutdownVMDaemon(virConnectPtr conn, close(vm->monitor); vm->monitor = -1; + if (vm->monitor_chr) { + if (vm->monitor_chr->type == VIR_DOMAIN_CHR_TYPE_UNIX) + unlink(vm->monitor_chr->data.nix.path); + virDomainChrDefFree(vm->monitor_chr); + vm->monitor_chr = NULL; + } + /* shut it off for sure */ virKillProcess(vm->pid, SIGKILL);