External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: volume: Mark optional 'pool' argument as 'positional'

Browse Source 
Annotate arguments which can be unintentionally parsed positionally.
(See previous commits for explanation.)

The pool name is optional but in all cases it can be promoted to an
optional positional argument so that it can be properly aligned with the
expectations of the parser.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2024-03-14 15:34:03 +01:00
parent 1304ef40a9
commit e31cd46364
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/virsh-volume.c
View File

@ -49,6 +49,7 @@
#define VIRSH_COMMON_OPT_POOL_OPTIONAL \ #define VIRSH_COMMON_OPT_POOL_OPTIONAL \
{.name = "pool", \ {.name = "pool", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.positional = true, \
.help = N_("pool name or uuid"), \ .help = N_("pool name or uuid"), \
.completer = virshStoragePoolNameCompleter, \ .completer = virshStoragePoolNameCompleter, \
.completer_flags = VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE, \ .completer_flags = VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE, \