External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Daemonize fuse thread in libvirt_lxc

Browse Source 
In some startup failure modes, the fuse thread may get itself
wedged. This will cause the entire libvirt_lxc process to
hang trying to the join the thread. There is no compelling
reason to wait for the thread to exit if the whole process
is exiting, so just daemonize the fuse thread instead.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-03-07 18:49:45 +00:00
parent 83d7e4e460
commit e31f32c6a3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lxc/lxc_fuse.c
View File

@ -320,7 +320,7 @@ int lxcSetupFuse(virLXCFusePtr *f, virDomainDefPtr def)
goto cleanup1; goto cleanup1;
} }
if (virThreadCreate(&fuse->thread, true, lxcFuseRun, if (virThreadCreate(&fuse->thread, false, lxcFuseRun,
(void *)fuse) < 0) { (void *)fuse) < 0) {
lxcFuseDestroy(fuse); lxcFuseDestroy(fuse);
goto cleanup1; goto cleanup1;
@ -351,8 +351,6 @@ void lxcFreeFuse(virLXCFusePtr *f)
fuse_exit(fuse->fuse); fuse_exit(fuse->fuse);
virMutexUnlock(&fuse->lock); virMutexUnlock(&fuse->lock);
virThreadJoin(&fuse->thread);
VIR_FREE(fuse->mountpoint); VIR_FREE(fuse->mountpoint);
VIR_FREE(*f); VIR_FREE(*f);
} }