External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-16 17:45:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't ignore return value of qemuProcessKill

Browse Source 
When calling qemuProcessKill from the virDomainDestroy impl
in QEMU, do not ignore the return value. This ensures that
if QEMU fails to respond to SIGKILL, the caller will know
about the failure.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit f1b4021b38f9485c50d386af6f682ecfc8025af5)
This commit is contained in:
Daniel P. Berrange 2012-09-27 10:07:03 +01:00 committed by Cole Robinson
parent 650a37faa5
commit e37286dadf
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_driver.c
View File

@ -1955,7 +1955,11 @@ qemuDomainDestroyFlags(virDomainPtr dom,
goto cleanup; goto cleanup;
} }
} else { } else {
ignore_value(qemuProcessKill(driver, vm, VIR_QEMU_PROCESS_KILL_FORCE)); if (qemuProcessKill(driver, vm, VIR_QEMU_PROCESS_KILL_FORCE) < 0) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
_("failed to kill qemu process with SIGTERM"));
goto cleanup;
}
} }
/* We need to prevent monitor EOF callback from doing our work (and sending /* We need to prevent monitor EOF callback from doing our work (and sending