External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemuxml2xmltest: testInfoSetPaths: Remove return value

Browse Source 
The function doesn't fail. Remove the return value and checks.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-03-26 18:53:32 +01:00
parent b5ee95561a
commit e4332faf39
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/qemuxml2xmltest.c
View File

@ -50,7 +50,7 @@ testXML2XMLInactive(const void *opaque)
} }
static int static void
testInfoSetPaths(struct testQemuInfo *info, testInfoSetPaths(struct testQemuInfo *info,
const char *suffix, const char *suffix,
int when) int when)
@ -71,8 +71,6 @@ testInfoSetPaths(struct testQemuInfo *info,
info->outfile = g_strdup_printf("%s/qemuxml2xmloutdata/%s%s.xml", info->outfile = g_strdup_printf("%s/qemuxml2xmloutdata/%s%s.xml",
abs_srcdir, info->name, suffix); abs_srcdir, info->name, suffix);
} }
return 0;
} }
@ -140,20 +138,14 @@ mymain(void)
} \ } \
\ \
if (when & WHEN_INACTIVE) { \ if (when & WHEN_INACTIVE) { \
if (testInfoSetPaths(&info, suffix, WHEN_INACTIVE) < 0) { \ testInfoSetPaths(&info, suffix, WHEN_INACTIVE); \
VIR_TEST_DEBUG("Failed to generate inactive paths for '%s'", _name); \
return -1; \
} \
if (virTestRun("QEMU XML-2-XML-inactive " _name, \ if (virTestRun("QEMU XML-2-XML-inactive " _name, \
testXML2XMLInactive, &info) < 0) \ testXML2XMLInactive, &info) < 0) \
ret = -1; \ ret = -1; \
} \ } \
\ \
if (when & WHEN_ACTIVE) { \ if (when & WHEN_ACTIVE) { \
if (testInfoSetPaths(&info, suffix, WHEN_ACTIVE) < 0) { \ testInfoSetPaths(&info, suffix, WHEN_ACTIVE); \
VIR_TEST_DEBUG("Failed to generate active paths for '%s'", _name); \
return -1; \
} \
if (virTestRun("QEMU XML-2-XML-active " _name, \ if (virTestRun("QEMU XML-2-XML-active " _name, \
testXML2XMLActive, &info) < 0) \ testXML2XMLActive, &info) < 0) \
ret = -1; \ ret = -1; \