From e4e62941f2b5da573a49a8eb66761b75cdcb0baf Mon Sep 17 00:00:00 2001 From: Christian Ehrhardt Date: Thu, 16 Jan 2020 09:13:28 +0100 Subject: [PATCH] test: let qemuhotplugtest report details of init fails If virHostdevManagerGetDefault in qemuhotplugtest fails it works for quite a while to later segfault when accessing mgr->activePCIHostdevs. Report the error details and break on a failed init to see the real issue right away. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrea Bolognani Signed-off-by: Christian Ehrhardt --- tests/qemuhotplugtest.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index a60c8d1c93..6a3e61c54b 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -634,6 +634,11 @@ mymain(void) return EXIT_FAILURE; driver.hostdevMgr = virHostdevManagerGetDefault(); + if (driver.hostdevMgr == NULL) { + VIR_TEST_VERBOSE("Could not initialize HostdevManager - %s\n", + virGetLastErrorMessage()); + return EXIT_FAILURE; + } #define DO_TEST(file, ACTION, dev, fial, kep, ...) \