External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemu: fix race between disk mirror fail and cancel

Browse Source 
If a VM migration is aborted, a disk mirror may be failed by QEMU before
libvirt has a chance to cancel it. The disk->mirrorState remains at
_ABORT in this case, and this breaks subsequent mirrorings of that disk.

We should instead check the mirrorState directly and transition to _NONE
if it is already aborted. Do the check *after* aborting the block job in
QEMU to avoid a race.

Signed-off-by: Michael Chapman <mike@very.puzzling.org>
This commit is contained in:
Michael Chapman 2015-03-30 13:41:00 +11:00 committed by Ján Tomko
parent 77ddd0bba2
commit e5d729ba42
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/qemu/qemu_migration.c
View File

@ -1853,6 +1853,10 @@ qemuMigrationDriveMirror(virQEMUDriverPtr driver,
} else { } else {
VIR_WARN("Unable to enter monitor. No block job cancelled"); VIR_WARN("Unable to enter monitor. No block job cancelled");
} }
/* If disk mirror is already aborted, clear the mirror state now */
if (disk->mirrorState == VIR_DOMAIN_DISK_MIRROR_STATE_ABORT)
disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_NONE;
} }
if (err) if (err)
virSetError(err); virSetError(err);
@ -1921,6 +1925,10 @@ qemuMigrationCancelDriveMirror(qemuMigrationCookiePtr mig,
ret = -1; ret = -1;
goto cleanup; goto cleanup;
} }
/* If disk mirror is already aborted, clear the mirror state now */
if (disk->mirrorState == VIR_DOMAIN_DISK_MIRROR_STATE_ABORT)
disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_NONE;
} }
cleanup: cleanup: