External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: fix enum conversion

Browse Source 
../src/conf/domain_conf.c:8144:78: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
        if ((def->writeFiltering = virTristateBoolTypeFromString(filtering)) < 0) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: 9d15647dcb96831c93ac8c1d67c47265b5ed9072
This commit is contained in:
Ján Tomko 2020-09-01 23:30:35 +02:00
parent cec43376fb
commit e603fcf537
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/domain_conf.c
View File

@ -8141,12 +8141,14 @@ virDomainHostdevSubsysPCIDefParseXML(xmlNodePtr node,
xmlNodePtr cur; xmlNodePtr cur;
if ((filtering = virXMLPropString(node, "writeFiltering"))) { if ((filtering = virXMLPropString(node, "writeFiltering"))) {
if ((def->writeFiltering = virTristateBoolTypeFromString(filtering)) < 0) { int val;
if ((val = virTristateBoolTypeFromString(filtering)) < 0) {
virReportError(VIR_ERR_XML_ERROR, virReportError(VIR_ERR_XML_ERROR,
_("unknown pci writeFiltering setting '%s'"), _("unknown pci writeFiltering setting '%s'"),
filtering); filtering);
return -1; return -1;
} }
def->writeFiltering = val;
} }
cur = node->children; cur = node->children;