External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-04 00:52:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

virt-host-validate: Initialize the error object

Browse Source 
Several libvirt functions are called from virt-host-validate.
Some of these functions do report an error on failure. But
reporting an error is coupled with freeing previous error (by
calling virResetError()). But we've never called
virErrorInitialize() and thus resetting error object frees some
random pointer.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
This commit is contained in:
Michal Privoznik 2021-06-08 08:53:14 +02:00
parent a190906977
commit e7ae82dcc5
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/virt-host-validate.c
View File

@ -27,6 +27,7 @@
#include <getopt.h>
#include "internal.h"
#include "virerror.h"
#include "virgettext.h"
#include "virt-host-validate-common.h"
@ -83,8 +84,11 @@ main(int argc, char **argv)
bool quiet = false;
bool usedHvname = false;
if (virGettextInitialize() < 0)
if (virGettextInitialize() < 0 ||
virErrorInitialize() < 0) {
fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
return EXIT_FAILURE;
}
while ((c = getopt_long(argc, argv, "hvq", argOptions, NULL)) != -1) {
switch (c) {