From e8e9a7e9f7485970c834428b5dce3fec5dc7b42e Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Wed, 15 Mar 2017 13:01:13 +0100 Subject: [PATCH] Expose virCapabilitiesFreeGuest Guests are handled in callers, but if something goes wrong (when it cannot be added to virCapabilities, for example), there's no way for them to free it properly. Signed-off-by: Martin Kletzander --- src/conf/capabilities.c | 2 +- src/conf/capabilities.h | 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 9ab343bc65..87e274c066 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -148,7 +148,7 @@ virCapabilitiesFreeGuestFeature(virCapsGuestFeaturePtr feature) VIR_FREE(feature); } -static void +void virCapabilitiesFreeGuest(virCapsGuestPtr guest) { size_t i; diff --git a/src/conf/capabilities.h b/src/conf/capabilities.h index cfdc34a66b..8634fda144 100644 --- a/src/conf/capabilities.h +++ b/src/conf/capabilities.h @@ -248,6 +248,9 @@ void virCapabilitiesFreeMachines(virCapsGuestMachinePtr *machines, int nmachines); +void +virCapabilitiesFreeGuest(virCapsGuestPtr guest); + virCapsGuestPtr virCapabilitiesAddGuest(virCapsPtr caps, int ostype, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 9dc3741732..f10322192c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -53,6 +53,7 @@ virCapabilitiesAllocMachines; virCapabilitiesClearHostNUMACellCPUTopology; virCapabilitiesDomainDataLookup; virCapabilitiesFormatXML; +virCapabilitiesFreeGuest; virCapabilitiesFreeMachines; virCapabilitiesFreeNUMAInfo; virCapabilitiesGetCpusForNodemask;