External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuDomainChrRemove: Don't leak vmdef->consoles[0]

Browse Source 
When removing the compat console from domain defintion, removing
it from the vmdef->consoles array is good, but not sufficient.
The console definition might have been fully allocated (after
daemon restarted and reloaded the status XML). Use
virDomainChrDefFree() to free also the definition.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2023-04-12 14:14:30 +02:00
parent 9129643d26
commit e99072731c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_hotplug.c
View File

@ -1937,8 +1937,10 @@ qemuDomainChrRemove(virDomainDef *vmdef,
return NULL;
}
if (removeCompat)
if (removeCompat) {
virDomainChrDefFree(vmdef->consoles[0]);
VIR_DELETE_ELEMENT(vmdef->consoles, 0, vmdef->nconsoles);
}
return ret;
}