From e9e3d6dff43cf90d4e5d8836de3b16e84c97400e Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 13 Mar 2024 22:45:04 +0100
Subject: [PATCH] virsh: Annotate rest of _ARGV arguments as positional
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In most cases it's the usual/recommended way to use those commands:

 $ virsh qemu-monitor-command VMNAME cmd args args args

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-domain.c  | 8 ++++++++
 tools/virsh-network.c | 1 +
 2 files changed, 9 insertions(+)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0bf4d524b0..801b01bb42 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -5000,6 +5000,7 @@ static const vshCmdOptDef opts_schedinfo[] = {
     VIRSH_COMMON_OPT_LIVE(N_("get/set value from running domain")),
     {.name = "set",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .flags = VSH_OFLAG_NONE,
      .help = N_("parameter=value")
     },
@@ -8188,6 +8189,7 @@ static const vshCmdOptDef opts_desc[] = {
     },
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .help = N_("message")
     },
     {.name = NULL}
@@ -8493,6 +8495,7 @@ static const vshCmdOptDef opts_send_key[] = {
     {.name = "keycode",
      .type = VSH_OT_ARGV,
      .required = true,
+     .positional = true,
      .completer = virshKeycodeNameCompleter,
      .help = N_("the key code")
     },
@@ -9600,6 +9603,7 @@ static const vshCmdOptDef opts_qemu_monitor_command[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command")
     },
@@ -9996,6 +10000,7 @@ static const vshCmdOptDef opts_qemu_agent_command[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command")
     },
@@ -10092,6 +10097,7 @@ static const vshCmdOptDef opts_lxc_enter_namespace[] = {
     },
     {.name = "cmd",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .required = true,
      .help = N_("command to run")
     },
@@ -12795,6 +12801,7 @@ static const vshCmdOptDef opts_domfsfreeze[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = "mountpoint",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .completer = virshDomainFSMountpointsCompleter,
      .help = N_("mountpoint path to be frozen")
     },
@@ -12835,6 +12842,7 @@ static const vshCmdOptDef opts_domfsthaw[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = "mountpoint",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .completer = virshDomainFSMountpointsCompleter,
      .help = N_("mountpoint path to be thawed")
     },
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 240d10eea7..59ca842181 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -324,6 +324,7 @@ static const vshCmdOptDef opts_network_desc[] = {
     },
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
+     .positional = true,
      .help = N_("message")
     },
     {.name = NULL}