External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virDomainFeaturesTCGDefParse: Don't leak 'tcg_features' when '<tcg>' feature is repeated

Browse Source 
Similarly to other cases users may specify the feature flag multiple
times.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2024-09-09 16:46:05 +02:00 committed by Pavel Hrdina
parent 574769ceb6
commit ead2419df3
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/conf/domain_conf.c
View File

@ -16807,21 +16807,25 @@ virDomainFeaturesTCGDefParse(virDomainDef *def,
xmlXPathContextPtr ctxt, xmlXPathContextPtr ctxt,
xmlNodePtr node) xmlNodePtr node)
{ {
g_autofree virDomainFeatureTCG *tcg = NULL; unsigned long long tb_cache;
VIR_XPATH_NODE_AUTORESTORE(ctxt); VIR_XPATH_NODE_AUTORESTORE(ctxt);
tcg = g_new0(virDomainFeatureTCG, 1);
ctxt->node = node; ctxt->node = node;
if (virDomainParseMemory("./tb-cache", "./tb-cache/@unit", if (virDomainParseMemory("./tb-cache", "./tb-cache/@unit",
ctxt, &tcg->tb_cache, false, false) < 0) ctxt, &tb_cache, false, false) < 0)
return -1; return -1;
if (tcg->tb_cache == 0) if (tb_cache == 0)
return 0; return 0;
if (!def->tcg_features)
def->tcg_features = g_new0(virDomainFeatureTCG, 1);
def->tcg_features->tb_cache = tb_cache;
def->features[VIR_DOMAIN_FEATURE_TCG] = VIR_TRISTATE_SWITCH_ON; def->features[VIR_DOMAIN_FEATURE_TCG] = VIR_TRISTATE_SWITCH_ON;
def->tcg_features = g_steal_pointer(&tcg);
return 0; return 0;
} }