diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index 346f7f522a..1c57475f81 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -277,7 +277,7 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED) data->keepalive_count = 5; data->keepalive_required = 0; - localhost = virGetHostname(NULL); + localhost = virGetHostname(); if (localhost == NULL) { /* we couldn't resolve the hostname; assume that we are * running in disconnected operation, and report a less diff --git a/src/check-driverimpls.pl b/src/check-driverimpls.pl index 2ba4864f6f..52b14e46c2 100755 --- a/src/check-driverimpls.pl +++ b/src/check-driverimpls.pl @@ -44,7 +44,6 @@ while (<>) { # External impls next if $prefix eq "node"; - next if $prefix eq "vir"; if (defined $mainprefix) { if ($mainprefix ne $prefix) { diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 736174320d..76468c5d1a 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1411,6 +1411,13 @@ libxlConnectGetVersion(virConnectPtr conn, unsigned long *version) return 0; } + +static char *libxlConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int libxlConnectGetMaxVcpus(virConnectPtr conn, const char *type ATTRIBUTE_UNUSED) { @@ -4203,7 +4210,7 @@ static virDriver libxlDriver = { .connectClose = libxlConnectClose, /* 0.9.0 */ .connectGetType = libxlConnectGetType, /* 0.9.0 */ .connectGetVersion = libxlConnectGetVersion, /* 0.9.0 */ - .connectGetHostname = virGetHostname, /* 0.9.0 */ + .connectGetHostname = libxlConnectGetHostname, /* 0.9.0 */ .connectGetMaxVcpus = libxlConnectGetMaxVcpus, /* 0.9.0 */ .nodeGetInfo = libxlNodeGetInfo, /* 0.9.0 */ .connectGetCapabilities = libxlConnectGetCapabilities, /* 0.9.0 */ diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 84a97de4fd..aef97a6ab7 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1562,6 +1562,13 @@ static int lxcConnectGetVersion(virConnectPtr conn ATTRIBUTE_UNUSED, unsigned lo } +static char *lxcConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + + /* * check whether the host supports CFS bandwidth * @@ -4402,7 +4409,7 @@ static virDriver lxcDriver = { .connectOpen = lxcConnectOpen, /* 0.4.2 */ .connectClose = lxcConnectClose, /* 0.4.2 */ .connectGetVersion = lxcConnectGetVersion, /* 0.4.6 */ - .connectGetHostname = virGetHostname, /* 0.6.3 */ + .connectGetHostname = lxcConnectGetHostname, /* 0.6.3 */ .connectGetSysinfo = lxcConnectGetSysinfo, /* 1.0.5 */ .nodeGetInfo = nodeGetInfo, /* 0.6.5 */ .connectGetCapabilities = lxcConnectGetCapabilities, /* 0.6.5 */ diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index e6d71466ad..b24e296178 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -343,6 +343,13 @@ static int openvzConnectGetVersion(virConnectPtr conn, unsigned long *version) { return 0; } + +static char *openvzConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static char *openvzDomainGetOSType(virDomainPtr dom) { struct openvz_driver *driver = dom->conn->privateData; @@ -2182,7 +2189,7 @@ static virDriver openvzDriver = { .connectClose = openvzConnectClose, /* 0.3.1 */ .connectGetType = openvzConnectGetType, /* 0.3.1 */ .connectGetVersion = openvzConnectGetVersion, /* 0.5.0 */ - .connectGetHostname = virGetHostname, /* 0.9.12 */ + .connectGetHostname = openvzConnectGetHostname, /* 0.9.12 */ .connectGetMaxVcpus = openvzConnectGetMaxVcpus, /* 0.4.6 */ .nodeGetInfo = nodeGetInfo, /* 0.3.2 */ .nodeGetCPUStats = nodeGetCPUStats, /* 0.9.12 */ diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index c29a5ba24d..45f31164a3 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -1043,6 +1043,13 @@ cleanup: return ret; } + +static char *parallelsConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int parallelsConnectListDomains(virConnectPtr conn, int *ids, int maxids) { @@ -2393,7 +2400,7 @@ static virDriver parallelsDriver = { .connectOpen = parallelsConnectOpen, /* 0.10.0 */ .connectClose = parallelsConnectClose, /* 0.10.0 */ .connectGetVersion = parallelsConnectGetVersion, /* 0.10.0 */ - .connectGetHostname = virGetHostname, /* 0.10.0 */ + .connectGetHostname = parallelsConnectGetHostname, /* 0.10.0 */ .nodeGetInfo = nodeGetInfo, /* 0.10.0 */ .connectGetCapabilities = parallelsConnectGetCapabilities, /* 0.10.0 */ .connectListDomains = parallelsConnectListDomains, /* 0.10.0 */ diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0aceb1760b..3f9172a802 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1412,6 +1412,13 @@ cleanup: return ret; } + +static char *qemuConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int qemuConnectListDomains(virConnectPtr conn, int *ids, int nids) { virQEMUDriverPtr driver = conn->privateData; int n; @@ -14703,7 +14710,7 @@ static virDriver qemuDriver = { .connectSupportsFeature = qemuConnectSupportsFeature, /* 0.5.0 */ .connectGetType = qemuConnectGetType, /* 0.2.0 */ .connectGetVersion = qemuConnectGetVersion, /* 0.2.0 */ - .connectGetHostname = virGetHostname, /* 0.3.3 */ + .connectGetHostname = qemuConnectGetHostname, /* 0.3.3 */ .connectGetSysinfo = qemuConnectGetSysinfo, /* 0.8.8 */ .connectGetMaxVcpus = qemuConnectGetMaxVcpus, /* 0.2.1 */ .nodeGetInfo = nodeGetInfo, /* 0.2.0 */ diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 733c0c4548..8ed94731b4 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -404,7 +404,7 @@ qemuMigrationCookieNew(virDomainObjPtr dom) goto no_memory; memcpy(mig->uuid, dom->def->uuid, VIR_UUID_BUFLEN); - if (!(mig->localHostname = virGetHostname(NULL))) + if (!(mig->localHostname = virGetHostname())) goto error; if (virGetHostUUID(mig->localHostuuid) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -2372,7 +2372,7 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, if (port == QEMUD_MIGRATION_NUM_PORTS) port = 0; /* Get hostname */ - if ((hostname = virGetHostname(NULL)) == NULL) + if ((hostname = virGetHostname()) == NULL) goto cleanup; if (STRPREFIX(hostname, "localhost")) { diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f60f106bb8..0fb2dcec49 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1223,6 +1223,12 @@ static int testConnectGetVersion(virConnectPtr conn ATTRIBUTE_UNUSED, return 0; } +static char *testConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int testConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) { return 1; @@ -5796,7 +5802,7 @@ static virDriver testDriver = { .connectOpen = testConnectOpen, /* 0.1.1 */ .connectClose = testConnectClose, /* 0.1.1 */ .connectGetVersion = testConnectGetVersion, /* 0.1.1 */ - .connectGetHostname = virGetHostname, /* 0.6.3 */ + .connectGetHostname = testConnectGetHostname, /* 0.6.3 */ .connectGetMaxVcpus = testConnectGetMaxVcpus, /* 0.3.2 */ .nodeGetInfo = testNodeGetInfo, /* 0.1.1 */ .connectGetCapabilities = testConnectGetCapabilities, /* 0.2.1 */ diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 66c00b2beb..9f13254a94 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1494,6 +1494,13 @@ cleanup: return ret; } + +static char *umlConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int umlConnectListDomains(virConnectPtr conn, int *ids, int nids) { struct uml_driver *driver = conn->privateData; int n; @@ -2597,7 +2604,7 @@ static virDriver umlDriver = { .connectClose = umlConnectClose, /* 0.5.0 */ .connectGetType = umlConnectGetType, /* 0.5.0 */ .connectGetVersion = umlConnectGetVersion, /* 0.5.0 */ - .connectGetHostname = virGetHostname, /* 0.5.0 */ + .connectGetHostname = umlConnectGetHostname, /* 0.5.0 */ .nodeGetInfo = nodeGetInfo, /* 0.5.0 */ .connectGetCapabilities = umlConnectGetCapabilities, /* 0.5.0 */ .connectListDomains = umlConnectListDomains, /* 0.5.0 */ diff --git a/src/util/virutil.c b/src/util/virutil.c index 982d4a3345..de1937c460 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1942,7 +1942,7 @@ char *virIndexToDiskName(int idx, const char *prefix) * we got from getaddrinfo(). Return the value from gethostname() * and hope for the best. */ -char *virGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +char *virGetHostname(void) { int r; char hostname[HOST_NAME_MAX+1], *result; diff --git a/src/util/virutil.h b/src/util/virutil.h index 8a2d25cdad..4c0a9a5c4a 100644 --- a/src/util/virutil.h +++ b/src/util/virutil.h @@ -211,7 +211,7 @@ static inline int geteuid (void) { return 0; } static inline int getgid (void) { return 0; } # endif -char *virGetHostname(virConnectPtr conn); +char *virGetHostname(void); char *virGetUserDirectory(void); char *virGetUserConfigDirectory(void); diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 43ddac8a61..af2ab0a964 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1090,6 +1090,13 @@ static int vboxConnectGetVersion(virConnectPtr conn, unsigned long *version) { return 0; } + +static char *vboxConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int vboxConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) { /* Driver is using local, non-network based transport */ return 1; @@ -9409,7 +9416,7 @@ virDriver NAME(Driver) = { .connectOpen = vboxConnectOpen, /* 0.6.3 */ .connectClose = vboxConnectClose, /* 0.6.3 */ .connectGetVersion = vboxConnectGetVersion, /* 0.6.3 */ - .connectGetHostname = virGetHostname, /* 0.6.3 */ + .connectGetHostname = vboxConnectGetHostname, /* 0.6.3 */ .connectGetMaxVcpus = vboxConnectGetMaxVcpus, /* 0.6.3 */ .nodeGetInfo = nodeGetInfo, /* 0.6.3 */ .connectGetCapabilities = vboxConnectGetCapabilities, /* 0.6.3 */ diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 6ad050c4ee..35430ff5a6 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -546,6 +546,13 @@ xenUnifiedConnectGetVersion(virConnectPtr conn, unsigned long *hvVer) return -1; } + +static char *xenUnifiedConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED) +{ + return virGetHostname(); +} + + static int xenUnifiedConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) { @@ -2353,7 +2360,7 @@ static virDriver xenUnifiedDriver = { .connectSupportsFeature = xenUnifiedConnectSupportsFeature, /* 0.3.2 */ .connectGetType = xenUnifiedConnectGetType, /* 0.0.3 */ .connectGetVersion = xenUnifiedConnectGetVersion, /* 0.0.3 */ - .connectGetHostname = virGetHostname, /* 0.7.3 */ + .connectGetHostname = xenUnifiedConnectGetHostname, /* 0.7.3 */ .connectGetMaxVcpus = xenUnifiedConnectGetMaxVcpus, /* 0.2.1 */ .nodeGetInfo = xenUnifiedNodeGetInfo, /* 0.1.0 */ .connectGetCapabilities = xenUnifiedConnectGetCapabilities, /* 0.2.1 */ diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 97f44abe4a..a41a22276a 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -2926,7 +2926,7 @@ xenDaemonDomainSetAutostart(virDomainPtr domain, int autostart) } int -xenDaemonDomainMigratePrepare(virConnectPtr dconn, +xenDaemonDomainMigratePrepare(virConnectPtr dconn ATTRIBUTE_UNUSED, char **cookie ATTRIBUTE_UNUSED, int *cookielen ATTRIBUTE_UNUSED, const char *uri_in, @@ -2942,7 +2942,7 @@ xenDaemonDomainMigratePrepare(virConnectPtr dconn, * deallocates this string. */ if (uri_in == NULL) { - *uri_out = virGetHostname(dconn); + *uri_out = virGetHostname(); if (*uri_out == NULL) return -1; }