From eae19bb505d472bd55764d9cd63b0319b9e131c3 Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Tue, 10 Sep 2024 15:22:13 +0200 Subject: [PATCH] resctrl: Account for memory bandwidth of 0 being valid In some scenarios the memory bandwidth in the schemata file might be 0 and so can the minimum allocation in other ones. Remove checks which were added for extra cautiousness. Resolves: https://issues.redhat.com/browse/RHEL-54235 Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- src/util/virresctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 30ae25c487..8ed111c182 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -1425,8 +1425,7 @@ virResctrlAllocParseProcessMemoryBandwidth(virResctrlInfo *resctrl, _("Invalid bandwidth %1$u"), bandwidth); return -1; } - if (bandwidth < resctrl->membw_info->min_bandwidth || - id > resctrl->membw_info->max_id) { + if (id > resctrl->membw_info->max_id) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Missing or inconsistent resctrl info for memory bandwidth node '%1$u'"), id); @@ -1463,7 +1462,6 @@ virResctrlAllocParseMemoryBandwidthLine(virResctrlInfo *resctrl, return 0; if (!resctrl || !resctrl->membw_info || - !resctrl->membw_info->min_bandwidth || !resctrl->membw_info->bandwidth_granularity) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing or inconsistent resctrl info for memory bandwidth allocation"));