External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: pcivpd: Refactor virPCIVPDResourceIsValidTextValue

Browse Source 
The function is never called with NULL argument. Remove the check and
refactor the rest including the debug statement.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2024-01-24 15:53:39 +01:00
parent 42df6cc1b4
commit eb3844009d
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/util/virpcivpd.c
View File

@ -175,23 +175,18 @@ virPCIVPDResourceGetFieldValueFormat(const char *keyword)
bool
virPCIVPDResourceIsValidTextValue(const char *value)
{
size_t i = 0;
const char *v;
bool ret = true;
if (value == NULL)
return false;
/* An empty string is a valid value. */
if (STREQ(value, ""))
return true;
while (i < strlen(value)) {
if (!g_ascii_isprint(value[i])) {
VIR_DEBUG("The provided value contains non-ASCII printable characters: %s", value);
return false;
for (v = value; *v; v++) {
if (!g_ascii_isprint(*v)) {
ret = false;
break;
}
++i;
}
return true;
VIR_DEBUG("val='%s' ret='%d'", value, ret);
return ret;
}
void