External/libvirt
1
0
Fork 0
Code

conf: remove misleading comments about access being 'lockless'

Browse Source 
For the various structs storing lists of objects, the access
to the hash tables is not lockless. The mutex on the object
owning the hash table must be held.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2022-03-08 16:56:05 +00:00
parent 79c613ec8a
commit ec8e185cd0
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/virdomainobjlist.c
View File

@ -46,11 +46,11 @@ struct _virDomainObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* uuid string -> virDomainObj mapping /* uuid string -> virDomainObj mapping
* for O(1), lockless lookup-by-uuid */ * for O(1), lookup-by-uuid */
GHashTable *objs; GHashTable *objs;
/* name -> virDomainObj mapping for O(1), /* name -> virDomainObj mapping for O(1),
* lockless lookup-by-name */ * lookup-by-name */
GHashTable *objsName; GHashTable *objsName;
}; };

2
src/conf/virinterfaceobj.c
View File

@ -44,7 +44,7 @@ struct _virInterfaceObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* name string -> virInterfaceObj mapping /* name string -> virInterfaceObj mapping
* for O(1), lockless lookup-by-name */ * for O(1), lookup-by-name */
GHashTable *objsName; GHashTable *objsName;
}; };

2
src/conf/virnodedeviceobj.c
View File

@ -48,7 +48,7 @@ struct _virNodeDeviceObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* name string -> virNodeDeviceObj mapping /* name string -> virNodeDeviceObj mapping
* for O(1), lockless lookup-by-name */ * for O(1), lookup-by-name */
GHashTable *objs; GHashTable *objs;
}; };

2
src/conf/virnwfilterbindingobjlist.c
View File

@ -39,7 +39,7 @@ struct _virNWFilterBindingObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* port dev name -> virNWFilterBindingObj mapping /* port dev name -> virNWFilterBindingObj mapping
* for O(1), lockless lookup-by-port dev */ * for O(1), lookup-by-port dev */
GHashTable *objs; GHashTable *objs;
}; };

2
src/conf/virsecretobj.c
View File

@ -54,7 +54,7 @@ struct _virSecretObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* uuid string -> virSecretObj mapping /* uuid string -> virSecretObj mapping
* for O(1), lockless lookup-by-uuid */ * for O(1), lookup-by-uuid */
GHashTable *objs; GHashTable *objs;
}; };

10
src/conf/virstorageobj.c
View File

@ -66,15 +66,15 @@ struct _virStorageVolObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* key string -> virStorageVolObj mapping /* key string -> virStorageVolObj mapping
* for (1), lockless lookup-by-key */ * for (1), lookup-by-key */
GHashTable *objsKey; GHashTable *objsKey;
/* name string -> virStorageVolObj mapping /* name string -> virStorageVolObj mapping
* for (1), lockless lookup-by-name */ * for (1), lookup-by-name */
GHashTable *objsName; GHashTable *objsName;
/* path string -> virStorageVolObj mapping /* path string -> virStorageVolObj mapping
* for (1), lockless lookup-by-path */ * for (1), lookup-by-path */
GHashTable *objsPath; GHashTable *objsPath;
}; };
@ -98,11 +98,11 @@ struct _virStoragePoolObjList {
virObjectRWLockable parent; virObjectRWLockable parent;
/* uuid string -> virStoragePoolObj mapping /* uuid string -> virStoragePoolObj mapping
* for (1), lockless lookup-by-uuid */ * for (1), lookup-by-uuid */
GHashTable *objs; GHashTable *objs;
/* name string -> virStoragePoolObj mapping /* name string -> virStoragePoolObj mapping
* for (1), lockless lookup-by-name */ * for (1), lookup-by-name */
GHashTable *objsName; GHashTable *objsName;
}; };