From ed039abc09bce5c890881a2b3b456f536fc6014a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Krze=C5=9Bniak?= Date: Mon, 20 Dec 2010 12:31:19 +0100 Subject: [PATCH] bridge_driver: avoid double call to VIR_FREE While not technically a double free (since VIR_FREE NULLs the pointer), this is unnecessary extra code. This crept in when the function was converted from virRun to virCommand. The AUTHORS file has also been updated. --- AUTHORS | 1 + src/network/bridge_driver.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index e065b185dc..b204bd6e09 100644 --- a/AUTHORS +++ b/AUTHORS @@ -141,6 +141,7 @@ Patches have also been contributed by: MORITA Kazutaka Josh Durgin Roopa Prabhu + Paweł Krześniak [....send patches to get your name here....] diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c3f32d7826..b0834ae2cb 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -557,7 +557,6 @@ dhcpStartDhcpDaemon(virNetworkObjPtr network) cmd = virCommandNew(DNSMASQ); if (networkBuildDnsmasqArgv(network, pidfile, cmd) < 0) { - VIR_FREE(pidfile); goto cleanup; }